Add appropriate inttypes.h headers to test files #83
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing compilation errors on CentOS 7 with GCC 4.8.5 because of the use of PRIdPTR.
This was causing compilation errors on CentOS 7 with GCC 4.8.5 due to the use of PRIdPTR.
|
Hi,
You should add the defines in either of them or both. Maybe the |
|
Can you try without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling mkclean from source on CentOS 7 (GCC 4.8.5), the use of PRIdPTR was causing a compilation error because the inttypes.h header and appropriate macro were not present in the offending test files.
Monkey-patching the lines into the test files fixed the compilation error, so I thought I'd create a pull here.