Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
rkyv
feature and all the trait implementations that came with it.The deserialization world contains various frameworks, each coming with their own strengths and weaknesses. It can be argued that it is too opinionated to support one over the other for a library.
Additionally, adding the code bloat of implementing traits for all types and their entire contained data is pretty much always overkill. Chances are users would only need support for very few types. And even when handling those types, serialization can often times be significantly improved by ignoring all pieces of irrelevant data.
For people that depended on the
rkyv
feature, I recommend to look into therkyv::with::{ArchiveWith, SerializeWith, DeserializeWith}
traits which essentially allow trait implementations ofrkyv::{Archive, Serialize, Deserialize}
on remote types. Therkyv-with
even provides a way to derive those*With
traits.