Performance Enhancements and Memory Footprint Reduction in mbedtls_internal_sha(256|512)_process_c() #9542
+191
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoel-serafim
force-pushed
the
development
branch
from
a95953d to
cb155f4
Compare
manoel-serafim
force-pushed
the
development
branch
from
849738e to
d42125f
Compare
|
Hello @gilles-peskine-arm ! As we discussed in the issue referenced in this PR, I've completed benchmarking these changes on both x86-64 and ARMv8 (With Clang and gcc). I would be happy to share the results— Is there any preferred method for receiving them? |
Please just post them to GitHub. |
manoel-serafim
force-pushed
the
development
branch
from
9a8dab0 to
9b02889
Compare
…e inside the first 16 intermediate hash calculations Signed-off-by: Manoel Serafim <[email protected]>
…f MBEDTLS_SHA256_SMALLER Signed-off-by: Manoel Serafim <[email protected]>
… K, now we directly add to i and use it as a general index as it should be used Signed-off-by: Manoel Serafim <[email protected]>
…on is unrroled for performance, however continues in a loop when MBEDTLS_SHA256_SMALLER is defined Signed-off-by: Manoel Serafim <[email protected]>
…rolling one loop Signed-off-by: Manoel Serafim <[email protected]>
Signed-off-by: Manoel Serafim <[email protected]>
… sha512 also Signed-off-by: Manoel Serafim <[email protected]>
Signed-off-by: Manoel Serafim <[email protected]>
Signed-off-by: Manoel Serafim <[email protected]>
Signed-off-by: Manoel Serafim <[email protected]>
manoel-serafim
force-pushed
the
development
branch
from
f594ca6 to
8817a17
Compare
gilles-peskine-arm
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR regards to performance and memory footprint improvements inside the compression functions of sha512.c and sha256.c.
This PR solves #9467 in the sense that it merges the word schedule and intermediate digest state loops. It also makes the code defined under MBEDTLS_SHA512_SMALLER even smaller and recicles operations inside the intermediate digest state loops.
PR checklist