Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DHE-PSK key exchange #9910

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Remove DHE-PSK key exchange #9910

wants to merge 10 commits into from

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Jan 15, 2025 •
edited
Loading

Description

Resolves #9684

Depends on Mbed-TLS/TF-PSA-Crypto#143 as per this comment

PR checklist

  • changelog provided
  • development PR provided
  • framework PR not required
  • 3.6 PR provided # | not required because:
  • 2.28 PR provided # | not required because:
  • tests provided | not required because:

@valeriosetti
ssl-opt.sh: remove DHE-PSK only test cases
f77b6c0 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
tests: do not use DHE-PSK key exchange in gnutls tests
b6f4f81 
DHE-PSK is being removed from Mbed TLS so we cannot use this key
exchange with gnutls testing.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
compat.sh: remove usage of DHE-PSK
01e7482 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
ssl_tls: remove usage of DHE-PSK
fb7af11 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
ssl_ciphersuites: remove references/usages of DHE-PSK
cea3b91 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
analyze_outcomes.py: remove exceptions related to DHE-PSK
dbaf9dd 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
check_config: remove checks for DHE-PSK
4f56956 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
mbedtls_config: remove MBEDTLS_KEY_EXCHANGE_DHE_PSK_ENABLED
ab193b5 
This commit also removes its disabling from config_adjust_ssl.h

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
docs: remove references of DHE-PSK
d0a9758 
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti self-assigned this Jan 15, 2025
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Jan 15, 2025
@valeriosetti valeriosetti mentioned this pull request Jan 15, 2025
Closed
3 tasks
@valeriosetti
Copy link
Contributor Author

valeriosetti commented Jan 16, 2025 •
edited
Loading

Note for reviewers: the failure on check_names test is expected and should be solved by Mbed-TLS/TF-PSA-Crypto#143. Therefore I'm removing the need-ci label

@valeriosetti valeriosetti added needs-preceding-pr Requires another PR to be merged first and removed needs-ci Needs to pass CI tests labels Jan 16, 2025
@ronald-cron-arm ronald-cron-arm self-requested a review January 17, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm Awaiting requested review from ronald-cron-arm

At least 2 approving reviews are required to merge this pull request.

Assignees

@valeriosetti valeriosetti

Labels
needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove DHE-PSK key exchange
1 participant
@valeriosetti