Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of simple-icons-font? #1421

Open
melroy89 opened this issue Feb 4, 2025 · 3 comments
Open

Get rid of simple-icons-font? #1421

melroy89 opened this issue Feb 4, 2025 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end

Comments

@melroy89
Copy link
Member

melroy89 commented Feb 4, 2025

Is your feature request related to a problem? Please describe.

Get rid of the simple-icons-font package. Since it will add a lot of icons and therefor more MBs to the overall size of the bundle.

Currently, we do use it. But apparently only at two places:

<a href="{{ path('oauth_simplelogin_connect') }}" class="btn btn__secondary"><i class="si si-simplelogin" aria-hidden="true"></i>

<a href="{{ path('oauth_authentik_connect') }}" class="btn btn__secondary"><i class="si si-authentik" aria-hidden="true"></i>

Describe the solution you'd like

Let's see if we can leverage existing icon sets we already have like Font awesome.

Describe alternatives you've considered

Keep it as is?

Additional context

Brought up during PR: #1417

@melroy89 melroy89 added dependencies Pull requests that update a dependency file enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Feb 4, 2025
@melroy89
Copy link
Member Author

melroy89 commented Feb 4, 2025

There is another alternative, which is using https://icomoon.io/.

That site allows you to cherry pick icons. And bundle & package only the icons you really need!

@LitoMore
Copy link

LitoMore commented Feb 9, 2025

See https://github.com/simple-icons/simple-icons-font?tab=readme-ov-file#custom-builds

You can custom-build the font file as you want.

@melroy89
Copy link
Member Author

melroy89 commented Feb 9, 2025

See https://github.com/simple-icons/simple-icons-font?tab=readme-ov-file#custom-builds

You can custom-build the font file as you want.

Thanks, that is also a possibility if these icons are not in Fontawesome or we don't want to use icomoon. Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Development

No branches or pull requests

2 participants