Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages #1417

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Update npm packages #1417

merged 2 commits into from
Feb 4, 2025

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Feb 3, 2025

Small minor release updates in NPM packages. So basically npm update.

Only updated the simple-icons-font package to a new major release. So far running at kbin.melroy.org, without issues.

@melroy89 melroy89 added the dependencies Pull requests that update a dependency file label Feb 3, 2025
@melroy89 melroy89 requested review from BentiGorlich and jwr1 February 3, 2025 22:55
Copy link
Member

@jwr1 jwr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really using a whole font for two icons? All I can see are these two:

<a href="{{ path('oauth_simplelogin_connect') }}" class="btn btn__secondary"><i class="si si-simplelogin" aria-hidden="true"></i>

<a href="{{ path('oauth_authentik_connect') }}" class="btn btn__secondary"><i class="si si-authentik" aria-hidden="true"></i>

Either way, upgrade looks good 👍.

@melroy89
Copy link
Member Author

melroy89 commented Feb 4, 2025

Are we really using a whole font for two icons? All I can see are these two:

haha yes apparently. Maybe we could use other fonts we already have like font awesome (fa)..? Maybe a good follow-up. Will create a ticket for that.

@melroy89
Copy link
Member Author

melroy89 commented Feb 4, 2025

Follow-up: #1421

@melroy89 melroy89 enabled auto-merge (squash) February 4, 2025 01:14
@melroy89 melroy89 merged commit 5d15e99 into main Feb 4, 2025
7 checks passed
@melroy89 melroy89 deleted the minor_package_updates branch February 4, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants