Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zip generation for 7zip #39

Closed
wants to merge 14 commits into from

Conversation

DeepDiver1975
Copy link

Fix issue #37

@glannes31
Copy link

Any update ??? We have the problem in owncloud 10.0.3 .

@DeepDiver1975
Copy link
Author

Any update ??? We have the problem in owncloud 10.0.3 .

10.0.4 already fixes this issue - please upgrade

@LorbusChris
Copy link

LorbusChris commented Feb 8, 2018

Any chance this is getting merged soon?

@DeepDiver1975
Copy link
Author

Any chance this is getting merged soon?

I consider this repo dead - feel free to grab the changes from my fork.

@LorbusChris
Copy link

LorbusChris commented Feb 8, 2018

Ok, thank you for the info. I will resort to bundling the vendored/patched version of it with NC :)

In the longer run I reckon there should either be a maintained fork of this or OC/NC should drop the dependency.

@DeepDiver1975
Copy link
Author

Ok, thank you for the info. I will resort to bundling the vendored/patched version of it with NC :)

In the longer run I reckon there should either be a maintained fork of this or OC/NC should drop the dependency.

FYI roland just started contributing to the my fork as well. as long as nobody cries - we can continue this way

@DeepDiver1975
Copy link
Author

Ok, thank you for the info. I will resort to bundling the vendored/patched version of it with NC :)

grab it from https://packagist.org/packages/deepdiver/zipstreamer

@LorbusChris
Copy link

Does this fork contain all changes required for NC? If you don't mind I will create an rpm package of your fork for Fedora, so I don't have to bundle it.

@DeepDiver1975
Copy link
Author

Does this fork contain all changes required for NC?

no idea - you need to talk with the nc guys

If you don't mind I will create an rpm package of your fork for Fedora, so I don't have to bundle it.

No issues with this - THX

rullzer and others added 5 commits March 8, 2018 08:40
As specified in 4.3.9.3 and 4.3.9.4

4.3.9.3 Although not originally assigned a signature, the value
      0x08074b50 has commonly been adopted as a signature value
      for the data descriptor record.  Implementers should be
      aware that ZIP files may be encountered with or without this
      signature marking data descriptors and SHOULD account for
      either case when reading ZIP files to ensure compatibility.

4.3.9.4 When writing ZIP files, implementors SHOULD include the
      signature value marking the data descriptor record.  When
      the signature is used, the fields currently defined for
      the data descriptor record will immediately follow the
      signature.

Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
@DeepDiver1975
Copy link
Author

I consider this repo dead ... feel free to use my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants