children: fix sort parameter #898

McShelby · Aug 29, 2024 · c9a32e7 · c9a32e7
1 parent 28975d0
commit c9a32e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/exampleSite/content/shortcodes/children/_index.en.md b/exampleSite/content/shortcodes/children/_index.en.md
@@ -6,7 +6,7 @@ title = "Children"
 
 The `children` shortcode lists the child pages of the current page and its descendants.
 
-{{% children sort="weight" %}}
+{{% children sort="title" %}}
 
 ## Usage
 
@@ -16,7 +16,7 @@ While the examples are using shortcodes with named parameter you are free to als
 {{% tab title="shortcode" %}}
 
 ````go
-{{%/* children sort="weight" */%}}
+{{%/* children sort="title" */%}}
 ````
 
 {{% /tab %}}
@@ -25,7 +25,7 @@ While the examples are using shortcodes with named parameter you are free to als
 ````go
 {{ partial "shortcodes/children.html" (dict
   "page" .
-  "sort" "weight"
+  "sort" "title"
 )}}
 ````
 
@@ -48,7 +48,7 @@ While the examples are using shortcodes with named parameter you are free to als
 ### All Default
 
 ````go
-{{%/* children  */%}}
+{{%/* children */%}}
 ````
 
 {{% children %}}

diff --git a/layouts/partials/shortcodes/children.html b/layouts/partials/shortcodes/children.html
@@ -21,7 +21,7 @@
 
 {{- with $page }}
 {{ (printf "<%s class=\"children children-%s children-sort-%s\">" $containerstyle $style $sortTerm)|safeHTML }}
-	{{- $pages := partial "pageHelper/pagesBy.html" (dict "page" .) }}
+	{{- $pages := partial "pageHelper/pagesBy.html" (dict "page" . "by" $sortTerm) }}
 	{{- template "childs" dict "menu" $pages "containerstyle" $containerstyle "style" $style "showhidden" $showhidden "count" 1 "depth" $depth "pages" .Site.Pages "description" $withDescription "sortTerm" $sortTerm "page" . }}
 {{ (printf "</%s>" $containerstyle)|safeHTML }}
 {{- end }}
@@ -66,7 +66,7 @@
 {{- (printf "<%s>" $.containerstyle)|safeHTML }}
 				{{- end }}
 
-				{{- $pages := partial "pageHelper/pagesBy.html" (dict "page" .) }}
+				{{- $pages := partial "pageHelper/pagesBy.html" (dict "page" . "by" $.sortTerm) }}
 				{{- template "childs" dict "menu" $pages "containerstyle" $.containerstyle "style" $.style "showhidden" $.showhidden "count" (add $.count 1) "depth" $.depth "pages" $.pages "description" $.description "sortTerm" $.sortTerm "page" $page }}
 
 				{{- if eq $.style "li" }}