a11y: use native button elements where appropriate #982

McShelby · Jan 1, 2025 · ee07f8f · ee07f8f
1 parent 8c403f2
commit ee07f8f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/assets/css/theme.css b/assets/css/theme.css
@@ -1479,7 +1479,7 @@ pre:not(.mermaid) .copy-to-clipboard-button:hover {
   color: var(--INTERNAL-CODE-BLOCK-BG-color);
 }
 
-.disableInlineCopyToClipboard span > code.copy-to-clipboard-code + span.copy-to-clipboard-button {
+.disableInlineCopyToClipboard span > code.copy-to-clipboard-code + .copy-to-clipboard-button {
   display: none;
 }
 
@@ -1821,6 +1821,7 @@ html[dir='rtl'] .expand[open] > .box-label > i.expander-icon {
 
 /* anchors */
 .anchor {
+  background-color: transparent;
   color: var(--INTERNAL-MAIN-LINK-color);
   cursor: pointer;
   font-size: 0.5em;

diff --git a/layouts/partials/version.txt b/layouts/partials/version.txt
@@ -1 +1 @@
-7.2.1+6747b8862e1ea7331662a6376ef02a48126816ae
+7.2.1+8c403f2aadf03c87f7741ead8e4c5425cbe30ed1
diff --git a/static/js/theme.js b/static/js/theme.js
@@ -336,7 +336,7 @@ function initMermaid(update, attrs) {
           var svg = d3.select(this);
           svg.html('<g>' + svg.html() + '</g>');
           var inner = svg.select('*:scope > g');
-          parent.insertAdjacentHTML('beforeend', '<span class="svg-reset-button" title="' + window.T_Reset_view + '"><i class="fas fa-undo-alt"></i></span>');
+          parent.insertAdjacentHTML('beforeend', '<button class="svg-reset-button" title="' + window.T_Reset_view + '"><i class="fas fa-undo-alt"></i></button>');
           var button = parent.querySelector('.svg-reset-button');
           var zoom = d3.zoom().on('zoom', function (e) {
             inner.attr('transform', e.transform);
@@ -530,7 +530,7 @@ function initAnchorClipboard() {
   document.querySelectorAll('h1~h2,h1~h3,h1~h4,h1~h5,h1~h6').forEach(function (element) {
     var url = encodeURI((document.location.origin == 'null' ? document.location.protocol + '//' + document.location.host : document.location.origin) + document.location.pathname);
     var link = url + '#' + element.id;
-    var new_element = document.createElement('span');
+    var new_element = document.createElement('button');
     new_element.classList.add('anchor');
     if (!window.relearn.disableAnchorCopy) {
       new_element.setAttribute('title', window.T_Copy_link_to_clipboard);
@@ -660,7 +660,7 @@ function initCodeClipboard() {
         code.parentNode.replaceChild(span, code);
         code = clone;
       }
-      var button = document.createElement('span');
+      var button = document.createElement('button');
       button.classList.add('copy-to-clipboard-button');
       button.setAttribute('title', window.T_Copy_to_clipboard);
       button.innerHTML = '<i class="far fa-copy"></i>';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		7.2.1+6747b8862e1ea7331662a6376ef02a48126816ae
		7.2.1+8c403f2aadf03c87f7741ead8e4c5425cbe30ed1