Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape HTML characters in mermaid #896

Closed
wants to merge 1 commit into from
Closed

Escape HTML characters in mermaid #896

wants to merge 1 commit into from

Conversation

koenyskout
Copy link

Addresses #895 by quoting special HTML characters in the pre block.

@koenyskout
Escape HTML characters in mermaid
ef5a994 
Addresses McShelby#895 by quoting special HTML characters in the pre block.
@koenyskout
Copy link
Author

I do not know what the original purpose of the replaceRE calls was. Using quotes still seems to work fine in the version with htmlEscape.

@McShelby McShelby added the invalid This doesn't seem right label Aug 29, 2024
@McShelby
Copy link
Owner

Thanks for submitting, but sadly this doesn't work when switching themes. I fixed it differnently and pushed it. Check it out.

@McShelby McShelby closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koenyskout @McShelby