Fixes #180, #181: Party Loot related issues, misc fixes (#182) (#183)

Features/ItemLoot.lua

@@ -81,6 +81,10 @@ function ItemLoot.Element:new(...)
 	local t
 	element.key, t, element.icon, element.quantity, element.sellPrice, element.unit = ...
 
+	if not G_RLF.db.global.enablePartyLoot then
+		element.unit = nil
+	end
+
 	function element:isPassingFilter(itemName, itemQuality)
 		if not G_RLF.db.global.itemQualityFilter[itemQuality] then
 			element:getLogger():Debug(
@@ -119,7 +123,10 @@ function ItemLoot.Element:new(...)
 	element.secondaryTextFn = function(...)
 		if element.unit then
 			local name, server = UnitName(element.unit)
-			return "    " .. name .. "-" .. server
+			if server then
+				return "    " .. name .. "-" .. server
+			end
+			return "    " .. name
 		end
 		local quantity = ...
 		if not element.sellPrice or element.sellPrice == 0 then

Features/LootDisplayProperties.lua

@@ -4,6 +4,8 @@ G_RLF.LootDisplayProperties = {
 	"key",
 	"textFn",
 	"secondaryTextFn",
+	"unit",
+	"sellPrice",
 	"isLink",
 	"icon",
 	"quantity",

Features/Reputation.lua

@@ -139,19 +139,16 @@ function Rep.Element:new(...)
 		elseif element.repType == RepType.Paragon then
 			local currentValue, threshold, _, hasRewardPending, tooLowLevelForParagon =
 				C_Reputation.GetFactionParagonInfo(element.factionId)
-			if tooLowLevelForParagon then
-				normalRep()
-			else
-				if hasRewardPending then
-					local bagSize = G_RLF.db.global.fontSize
-					str = str .. "|A:ParagonReputation_Bag:" .. bagSize .. ":" .. bagSize .. ":0:0|a    "
-				end
-				if currentValue ~= nil and currentValue > 0 then
-					str = str .. currentValue
-				end
-				if threshold ~= nil and threshold > 0 then
-					str = str .. "/" .. threshold
-				end
+
+			if hasRewardPending then
+				local bagSize = G_RLF.db.global.fontSize
+				str = str .. "|A:ParagonReputation_Bag:" .. bagSize .. ":" .. bagSize .. ":0:0|a    "
+			end
+			if currentValue ~= nil and currentValue > 0 then
+				str = str .. currentValue
+			end
+			if threshold ~= nil and threshold > 0 then
+				str = str .. "/" .. threshold
 			end
 		else
 			normalRep()

LootDisplay/LootDisplayFrame/LootDisplayRow/LootDisplayRow.lua

@@ -311,6 +311,7 @@ function LootDisplayRowMixin:Reset()
 	self.Icon:Reset()
 
 	self.UnitPortrait:SetTexture(nil)
+	self.SecondaryText:SetText(nil)
 
 	-- Reset amount text behavior
 	self.PrimaryText:SetScript("OnEnter", nil)
@@ -519,7 +520,7 @@ function LootDisplayRowMixin:UpdateWithHistoryData(data)
 	self.unit = data.unit
 	self.PrimaryText:SetText(data.rowText)
 	self.PrimaryText:SetTextColor(unpack(data.textColor))
-	if self.unit and data.secondaryText then
+	if self.unit and data.secondaryText and G_RLF.db.global.enabledSecondaryRowText then
 		self.secondaryText = data.secondaryText
 		self.SecondaryText:SetText(self.secondaryText)
 	end

SmokeTest.lua

@@ -152,8 +152,10 @@ local function runItemLootSmokeTest()
 		G_RLF:Print("Item not cached, skipping ItemLoot test")
 	else
 		runTestSafely(e.Show, "LootDisplay: Item", e, testObj.name, testObj.quality)
-		e = module.Element:new(testObj.id, testObj.link, testObj.icon, amountLooted)
+		e = module.Element:new(testObj.id, testObj.link, testObj.icon, amountLooted, testObj.sellPrice)
 		runTestSafely(e.Show, "LootDisplay: Item Quantity Update", e, testObj.name, testObj.quality)
+		e = module.Element:new(testObj.id, testObj.link, testObj.icon, amountLooted, nil, "player")
+		runTestSafely(e.Show, "LootDisplay: Item Unit", e, testObj.name, testObj.quality)
 	end
 end
 
@@ -217,7 +219,7 @@ local function testLootDisplay()
 	local frame = LootDisplayFrame
 	assertEqual(frame ~= nil, true, "LootDisplayFrame")
 	C_Timer.After(G_RLF.db.global.fadeOutDelay + 3, function()
-		assertEqual(#frame.rowHistory, 5, "LootDisplayFrame: rowHistory")
+		assertEqual(#frame.rowHistory, 6, true, "LootDisplayFrame: rowHistory")
 		displayResults()
 	end)
 end

TestMode.lua

@@ -162,6 +162,14 @@ local function generateRandomLoot()
 			local e = module.Element:new(item.id, item.link, item.icon, amountLooted, item.sellPrice)
 			e:Show(item.name, item.quality)
 
+			-- 10% chance of iitem loot to show up as a party member
+			if rng < 0.3 then
+				local unit = "player"
+				local module = G_RLF.RLF:GetModule("ItemLoot")
+				local e = module.Element:new(item.id, item.link, item.icon, amountLooted, item.sellPrice, unit)
+				e:Show(item.name, item.quality)
+			end
+
 			-- 15% chance to show currency
 		elseif rng > 0.7 and rng <= 0.85 then
 			local currency = testCurrencies[math.random(#testCurrencies)]