Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #106: Thanks @byezero! #116

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Close #106: Thanks @byezero! #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c46612
Ignore main locale file for missing translation check
Sep 9, 2024
4e8acb2
v1.6.1
Mctalian Sep 10, 2024
f596be7
Close #106: Thanks @byezero!
Mctalian Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .scripts/missing_translation_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def compare_translations(reference_dict, target_dict, locale):
def main():
locale_dir = "locale"
output_directory = ".scripts/.output"
ignored_files = ["main.lua"]

# Create output_directory if it doesn't exist
if not os.path.exists(output_directory):
Expand All @@ -113,6 +114,8 @@ def main():

# Compare each locale with the reference
for locale_file in locale_files:
if locale_file in ignored_files:
continue
if locale_file != reference_file:
target_dict = load_lua_file(f"{locale_dir}/{locale_file}")
markdown_report, extra_keys = compare_translations(
Expand Down
2 changes: 1 addition & 1 deletion Features/ItemLoot.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ local function showItemLoot(msg, itemLink)
local _, _, itemQuality, itemLevel, itemMinLevel, itemType, itemSubType, itemStackCount, itemEquipLoc, itemTexture, sellPrice, classID, subclassID, bindType, expansionID, setID, isCraftingReagent =
C_Item.GetItemInfo(itemLink)
if not G_RLF.db.global.itemQualityFilter[itemQuality] then
self:getLogger():Debug("Item Ignored by quality", G_RLF.addonName, "ItemLoot", "", msg, amount)
ItemLoot:getLogger():Debug("Item Ignored by quality", G_RLF.addonName, "ItemLoot", "", nil, amount)
return
end
local itemId = itemLink:match("Hitem:(%d+)")
Expand Down
2 changes: 2 additions & 0 deletions locale/zhCN.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,5 @@ L["UIParent"] = true
L["PlayerFrame"] = "玩家框架"
L["Minimap"] = "小地图"
L["BagBar"] = "背包栏"
L["Disable Row Highlight"] = "禁用行高亮"
L["DisableRowHighlightDesc"] = "如果选中，当你再次拾取相同的物品并且数量更新时，不再高亮显示该行。"
Loading