MAT-7238: refactor a few var names for clarity, fix indexing issue im…

[nmorasb]

…pacting failed row coloring

MADiE PR

Jira Ticket: MAT-7238
(Optional) Related Tickets:

Summary

All Submissions

• This PR has the JIRA linked.
• Required tests are included.
• No extemporaneous files are included (i.e Complied files or testing results).
• This PR is merging into the correct branch.
• All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
• Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

• This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
• All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

• Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
• The tests appropriately test the new code, including edge cases.
• If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (ea9eed9)	254	252	99.21%
Head commit (ca2421e)	253 (-1)	251 (-1)	99.21% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#15)	6	6	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}