Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6206: Adding ability to export TestCases as type 'Collection' #165

Closed

Conversation

gregory-akins
Copy link
Contributor

MADiE FHIR SERVICE

Jira Ticket: MAT-6206
(Optional) Related Tickets:

Summary

Adding logic to export TestCases with bundleType export.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@gregory-akins gregory-akins requested a review from a team as a code owner October 11, 2023 12:55
@@ -47,7 +40,7 @@ public ResponseEntity<String> getMeasureBundle(
@RequestBody @Validated(Measure.ValidationSequence.class) Measure measure,
@RequestHeader(value = HttpHeaders.ACCEPT, required = false) String accept,
@RequestHeader("Authorization") String accessToken,
@RequestParam(required = false, defaultValue = "calculation", name = "bundleType")
@RequestParam(required = false, defaultValue = "CALCULATION", name = "bundleType")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, this doesn't affect functionality, we can add tech debt. we have enum that maintains this https://github.com/MeasureAuthoringTool/madie-fhir-service/blob/develop/src/main/java/gov/cms/madie/madiefhirservice/utils/BundleUtil.java

@gregory-akins gregory-akins deleted the MAT-6206_TestCaseExportSpecifyCollection branch August 1, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants