Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6503: Disable HAPI IParser's Resource ID Override #185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Dec 1, 2023

MADiE FHIR SERVICE

Jira Ticket: MAT-6503
(Optional) Related Tickets:

Summary

When using HAPI's IParser to parse Bundle JSON, it has a default behavior of overriding Resource IDs with their FullUrls when the FullUrl is available and its IdPart matches the Resource ID. (See IParser Javadoc)

This was unexpected behavior and caused canonical URLs to be used as References when assembling the evaluatedResource component, when the intention was have local references.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

…upplied Resource ID with the FullUrl, when present and when its IdPart matches the Resource ID (which is pretty common in prod).
@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner December 1, 2023 20:32
@jkotanchik-SB jkotanchik-SB self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants