Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-8019: Skip Bundle validation for QICore STU6 Test Cases. #271

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Dec 13, 2024

MADiE FHIR SERVICE

Jira Ticket: MAT-8019
(Optional) Related Tickets:

Summary

Control validation skip via feature flag, stu6TestCaseValidation.

Bundle validation is generic, check for presence of a Patient Resource to ensure passed Bundle is a Test Case. When skipping validations, return a "Nothing to see here!"-esque response with just enough content to be used by the frontend.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner December 13, 2024 18:59
@jkotanchik-SB jkotanchik-SB self-assigned this Dec 13, 2024
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-8019-disable-stu6-test-case-validatons branch from 1e30e49 to 6d28188 Compare December 13, 2024 19:43
Bundle validation is generic, check for presence of a Patient Resource to ensure passed Bundle is a Test Case. When skipping validations, return a "Nothing to see here!"-esque response with just enough content to be used by the frontend.

Control validation skip via feature flag, stu6TestCaseValidation.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-8019-disable-stu6-test-case-validatons branch from 6d28188 to 6e2b425 Compare December 13, 2024 19:55
@jkotanchik-SB jkotanchik-SB merged commit 70ffde2 into develop Dec 13, 2024
5 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-8019-disable-stu6-test-case-validatons branch December 13, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants