Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-6193: QDM Test Case Coverage Tabs and Accordion #498

Merged
merged 20 commits into from
Nov 29, 2023
Merged

Conversation

ethankaplan
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6193
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@ethankaplan ethankaplan marked this pull request as ready for review November 21, 2023 23:21
@ethankaplan ethankaplan requested a review from a team as a code owner November 21, 2023 23:21
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e82d960) 87.47% compared to head (21f7dc5) 87.46%.

Files Patch % Lines
src/util/GroupCoverageHelpers.ts 83.33% 0 Missing and 2 partials ⚠️
...eLanding/qdm/TestCaseCoverage/TestCaseCoverage.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #498      +/-   ##
===========================================
- Coverage    87.47%   87.46%   -0.02%     
===========================================
  Files          160      163       +3     
  Lines         4599     4618      +19     
  Branches      1044     1047       +3     
===========================================
+ Hits          4023     4039      +16     
  Misses         316      316              
- Partials       260      263       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Nov 21, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e82d9601 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e82d960) Report Missing Report Missing Report Missing
Head commit (21f7dc5) 4251 3956 93.06%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#498) 21 21 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ethankaplan ethankaplan merged commit 6ddc72e into develop Nov 29, 2023
10 of 12 checks passed
@ethankaplan ethankaplan deleted the MAT-6193 branch December 1, 2023 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants