Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Mat 6473 upate cqm execution #504

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

sb-cecilialiu
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu commented Nov 27, 2023

MADiE PR

Jira Ticket: MAT-6473
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@sb-cecilialiu sb-cecilialiu requested a review from a team as a code owner November 27, 2023 16:50
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a744a6) 87.35% compared to head (0615746) 87.35%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #504   +/-   ##
========================================
  Coverage    87.35%   87.35%           
========================================
  Files          160      160           
  Lines         4602     4602           
  Branches      1046     1046           
========================================
  Hits          4020     4020           
  Misses         318      318           
  Partials       264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Nov 27, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a744a6) 4236 3939 92.99%
Head commit (0615746) 4236 (+0) 3939 (+0) 92.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#504) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

package.json Show resolved Hide resolved
@sb-cecilialiu sb-cecilialiu merged commit de2f05d into develop Nov 27, 2023
12 checks passed
@sb-cecilialiu sb-cecilialiu deleted the MAT-6473_upateCqmExecution branch November 27, 2023 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants