Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7854 Quantity value should be a number #748

Merged
merged 2 commits into from
Oct 29, 2024
Merged

MAT-7854 Quantity value should be a number #748

merged 2 commits into from
Oct 29, 2024

Conversation

adongare
Copy link
Contributor

@adongare adongare commented Oct 28, 2024

MADiE PR

Jira Ticket: MAT-7854
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@adongare adongare marked this pull request as ready for review October 28, 2024 18:39
@adongare adongare requested a review from a team as a code owner October 28, 2024 18:39
Copy link

codacy-production bot commented Oct 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (68e4bd2) 5692 5018 88.16%
Head commit (039bc7f) 5692 (+0) 5018 (+0) 88.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#748) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.98%. Comparing base (8f64976) to head (af8660d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #748   +/-   ##
========================================
  Coverage    82.98%   82.98%           
========================================
  Files          205      205           
  Lines         6155     6155           
  Branches      1334     1334           
========================================
  Hits          5108     5108           
  Misses         716      716           
  Partials       331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adongare adongare merged commit 5908eed into develop Oct 29, 2024
11 checks passed
@adongare adongare deleted the MAT-7854 branch October 29, 2024 12:18
@RohitKandimalla RohitKandimalla restored the MAT-7854 branch December 10, 2024 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants