Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

MAT-7822: Upgrading Fqm Execution fronm 1.5 - 1.6 #761

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

gregory-akins
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-7822
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is into the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

@gregory-akins gregory-akins requested a review from a team as a code owner November 12, 2024 15:49
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1781312) 5695 5024 88.22%
Head commit (092b9bd) 5695 (+0) 5024 (+0) 88.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#761) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (1781312) to head (092b9bd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #761   +/-   ##
========================================
  Coverage    83.30%   83.30%           
========================================
  Files          205      205           
  Lines         6181     6181           
  Branches      1345     1345           
========================================
  Hits          5149     5149           
  Misses         707      707           
  Partials       325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregory-akins gregory-akins merged commit e4fdf0d into develop Nov 12, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants