Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6675 added generate cms id feature flag #70

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

sb-prateekkeerthi
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-6675
(Optional) Related Tickets:

Summary

added generate cms id feature flag

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@sb-prateekkeerthi sb-prateekkeerthi requested a review from a team as a code owner February 14, 2024 16:19
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59d6495) 100.00% compared to head (0845c18) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           71        71           
  Branches        12        12           
=========================================
  Hits            71        71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sb-prateekkeerthi sb-prateekkeerthi merged commit 59c2b4b into develop Feb 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants