Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6917: Add endpoint for get all, add missing functionality for MAT-6916 #68

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

mcmcphillips
Copy link
Contributor

@mcmcphillips mcmcphillips commented Apr 2, 2024

Terminology Service PR

Jira Ticket: MAT-6917
(Optional) Related Tickets:
Jira Ticket: MAT-6916

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@mcmcphillips mcmcphillips requested a review from a team as a code owner April 2, 2024 22:54
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (5b5ee43) to head (36c9e43).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #68      +/-   ##
=============================================
+ Coverage      83.53%   84.17%   +0.63%     
- Complexity       173      177       +4     
=============================================
  Files             19       19              
  Lines            662      676      +14     
  Branches          52       52              
=============================================
+ Hits             553      569      +16     
+ Misses            84       83       -1     
+ Partials          25       24       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcmcphillips mcmcphillips changed the title MAT-6917: Add endpoint for get all, add tests MAT-6917: Add endpoint for get all, add missing functionality for MAT-6916 Apr 5, 2024
@mcmcphillips mcmcphillips merged commit 4f7d8f2 into develop Apr 5, 2024
8 checks passed
@mcmcphillips mcmcphillips deleted the MAT-6917 branch April 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants