Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adjust RepositoryServiceTest.testInvalidBranch #400

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

beiertu-mms
Copy link
Contributor

@beiertu-mms beiertu-mms commented Mar 19, 2024

The GHFileNotFoundException message has been changed and therefore
the test validation needs to be adjusted.

Also switch back push only trigger, because thepull_request_target
trigger runs on the main branch context, so it won't verify the actual
changes in a pull request.
Therefore, re-open the issue #378.

@technolinator-sbom-as-a-service
Copy link

technolinator-sbom-as-a-service bot commented Mar 19, 2024

Vulnerability Report

Please consider this as a tentative appraisal, consult Dependency-Track for reliable results.

Artifact Vulnerability Severity (CVSS v3) Recommendation
pkg:maven/org.bouncycastle/[email protected]?type=jar
CVE-2023-33201# Bouncy Castle For Java LDAP injection vulnerability
Bouncy Castle provides the X509LDAPCertStoreSpi.java class which can be used in conjunction with the CertPath API for validating certificate paths. Pre-1.73 the implementation did not check the X.500 name of any certificate, subject, or issuer being passed in for LDAP wild cards, meaning the presence of a wild car may lead to Information Disclosure.

A potential attack would be to generate a self-signed certificate with a subject name that contains special characters, e.g: CN=Subject*)(objectclass=. This will be included into the filter and provides the attacker ability to specify additional attributes in the search query. This can be exploited as a blind LDAP injection: an attacker can enumerate valid attribute values using the boolean blind injection technique. The exploitation depends on the structure of the target LDAP directory, as well as what kind of errors are exposed to the user.

Changes to the X509LDAPCertStoreSpi.java class add the additional checking of any X.500 name used to correctly escape wild card characters.
🟡 Medium (5.3)
pkg:maven/net.minidev/[email protected]?type=jar
CVE-2023-1370# json-smart Uncontrolled Recursion vulnerabilty
### Impact
Affected versions of net.minidev:json-smart are vulnerable to Denial of Service (DoS) due to a StackOverflowError when parsing a deeply nested JSON array or object.

When reaching a ‘[‘ or ‘{‘ character in the JSON input, the code parses an array or an object respectively. It was discovered that the 3PP does not have any limit to the nesting of such arrays or objects. Since the parsing of nested arrays and objects is done recursively, nesting too many of them can cause stack exhaustion (stack overflow) and crash the software.

### Patches
This vulnerability was fixed in json-smart version 2.4.9, but the maintainer recommends upgrading to 2.4.10, due to a remaining bug.

### Workarounds
N/A

### References
- https://www.cve.org/CVERecord?id=CVE-2023-1370
- https://nvd.nist.gov/vuln/detail/CVE-2023-1370
- https://security.snyk.io/vuln/SNYK-JAVA-NETMINIDEV-3369748
🟠 High (7.5) Update to 2.4.9 or later

The `GHFileNotFoundException` message has been changed and therefore
the test validation needs to be adjusted.
@beiertu-mms beiertu-mms force-pushed the test/adjust-repository-service-test branch from ac8f918 to fa22856 Compare March 19, 2024 16:39
heubeck
heubeck previously approved these changes Mar 19, 2024
Copy link
Member

@heubeck heubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@beiertu-mms beiertu-mms force-pushed the test/adjust-repository-service-test branch from 5f354a2 to e607784 Compare March 19, 2024 17:48
@beiertu-mms beiertu-mms added the bug Something isn't working label Mar 19, 2024
@beiertu-mms beiertu-mms marked this pull request as ready for review March 19, 2024 17:52
@beiertu-mms beiertu-mms requested a review from a team as a code owner March 19, 2024 17:52
@beiertu-mms beiertu-mms requested a review from heubeck March 19, 2024 17:53
@beiertu-mms
Copy link
Contributor Author

beiertu-mms commented Mar 19, 2024

@heubeck we would need to force-merge this one, because currently the pull_request_target one will always fail.
Switch back to push only for now.

@beiertu-mms beiertu-mms force-pushed the test/adjust-repository-service-test branch from e607784 to f677144 Compare March 19, 2024 17:54
@beiertu-mms beiertu-mms enabled auto-merge (squash) March 19, 2024 17:55
@beiertu-mms beiertu-mms disabled auto-merge March 19, 2024 21:14
@beiertu-mms beiertu-mms merged commit 14f0677 into main Mar 19, 2024
5 of 6 checks passed
@beiertu-mms beiertu-mms deleted the test/adjust-repository-service-test branch March 19, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants