Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler crash and profitability test in memset optimisation #22

Open
wants to merge 3 commits into
base: nanomips
Choose a base branch
from
Open

Fix compiler crash and profitability test in memset optimisation #22

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d27eb6
Fix compiler crash on undefined alignment memset
Jul 24, 2023
0fa7ee2
Adapt memset heuristics and tests for targets with unaligned accesses
Jul 31, 2023
7da624f
Fix denominator check
Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ void MemsetRanges::addRange(int64_t Start, int64_t Size, Value *Ptr,
I->Start = Start;
I->StartPtr = Ptr;
I->Alignment = Alignment;
if (I->MaxAlignmentOffset != 0)
if (I->MaxAlignment != 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This now makes sense.

I->MaxAlignmentOffset = (I->MaxAlignmentOffset + Size) % I->MaxAlignment;
else
I->MaxAlignmentOffset = 0;
cme marked this conversation as resolved.
Show resolved Hide resolved
Expand Down