This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Force a fixed version for request dependency due to non-availabilit…
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y of async/await function sin NodeJS versions 6.x/7x. `request` upgraded its version from 2.83.0 to 2.84.0, commiting a version change on its *package.json* file for the `hawk` NPM dependency, from 6.x to 7.x. Such `hawk` dependency version refers to the `sntp` library, which uses *async/await* statements in its codebase. Due to this dependency chain, new installs of `phantomjs` fail in environments that use NodeJS versions 6.x or 7.x, since these node versions do not support the async/await functions by default.
|
Will require version upgrade and NPM publishing of the newest version. |
|
Merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y of async/await function sin NodeJS versions 6.x/7x.
requestupgraded its version from 2.83.0 to 2.84.0, commiting a version change on its package.json file for thehawkNPM dependency, from 6.x to 7.x.Such
hawkdependency version refers to thesntplibrary, which uses async/await statements in its codebase.Due to this dependency chain, new installs of
phantomjsfail in environments that use NodeJS versions 6.x or 7.x, since these node versions do not support the async/await functions by default.