Fix deployment issues #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Greaves <[email protected]>
…oviding a value for the appropriate attr; in this case that's the _lsr private attribute of a WebHookMapping Signed-off-by: David Greaves <[email protected]>
keto
reviewed
Apr 7, 2017
src/webhook_launcher/app/models.py
Outdated
| @@ -476,7 +476,7 @@ def _get_build_message(self, user, force=None, handled=False, qp=None): | |||
| elif self.build: | |||
| parts.append( | |||
| "- which will trigger build in project %s package " | |||
| "%s (%s/package/show?package=%s&project=%s)" % ( | |||
| "%s (%s/package/show/%s/%s)" % ( | |||
| self.project, self.package, self.obs.weburl, | |||
| self.package, self.project, | |||
There was a problem hiding this comment.
I think package and project are backwards here for the new style OBS urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently deployed on Mer infra and works with the API GET/PUT
Triggers generally seem to work