Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 jb49609 #73

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Python3 jb49609 #73

wants to merge 8 commits into from

Conversation

lbt
Copy link
Member

@lbt lbt commented Aug 4, 2020

No description provided.

Daniel Suni and others added 8 commits May 22, 2020 08:47
Signed-off-by: David Greaves <[email protected]>
Signed-off-by: David Greaves <[email protected]>
The models.CASCADE value was the old implicit default

Signed-off-by: David Greaves <[email protected]>
encode is needed for hashlib now
dicts cannot be mutated during iteration so carry out the purge in 2 passes

Signed-off-by: David Greaves <[email protected]>
Use __str__ for python3 and also use format strings as they're clearer
and faster

Signed-off-by: David Greaves <[email protected]>
@lbt
Copy link
Member Author

lbt commented Aug 4, 2020

From Pami:
anyhow, only comment I have is now about the django migration
is the only change there for the help_texts from bytes to str?
if so, might make more sense to edit the existing migrations, as that is not a database affecting change
i.e. in old migrations they are help_text=b'...' so just drop the b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant