Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Container margins managements - MEED-2867-Meeds-io/MIPs#103 #1292

Merged
merged 3 commits into from
Nov 17, 2023
Merged

feat: Container margins managements - MEED-2867-Meeds-io/MIPs#103 #1292

merged 3 commits into from
Nov 17, 2023

Conversation

SaraBoutej
Copy link
Contributor

This change allows tp remove all paddings from the overview page portlet container.
A new Padding will be added as a CSS variable inside the less variables, so we can change this variable using the branding UI.

@SaraBoutej
feat: Margins cleanup - Remove extra-margins - MEED-2895-Meeds-io/MIP…
4cb3533 
…s#103 (#1283)

This change allows tp remove all paddings from the overview page portlet container.
The margin will be added as a CSS variable inside the less variables, so we can change this variable using the branding UI.

(cherry picked from commit e5452d5)
@SaraBoutej
feat: Remove extra-margins from containers - MEED-2866 -Meeds-io/MIPs…
3c4df1b 
…#103 (#1288)

(cherry picked from commit 4414964)
@SaraBoutej
feat: Container margins managements - MEED-2867-Meeds-io/MIPs#103 (#1290
1c8e5ed 
)

Remove extra padding top and bottom from col container

(cherry picked from commit c0eda9d)
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Nov 17, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@exo-swf exo-swf removed the partialCIBuild Perform Partial CI Build label Nov 17, 2023
@SaraBoutej SaraBoutej requested a review from boubaker November 17, 2023 08:52
@SaraBoutej SaraBoutej self-assigned this Nov 17, 2023
@SaraBoutej SaraBoutej merged commit e9b494f into develop-meed Nov 17, 2023
4 checks passed
@SaraBoutej SaraBoutej deleted the merge-2866-dev-meeds branch November 17, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boubaker boubaker boubaker approved these changes

Assignees

@SaraBoutej SaraBoutej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaraBoutej @boubaker @exo-swf