Fix: fix unable to save snv translation - EXO-75758 - Meeds-io/meeds#2642 #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2642 prior to this change, when editing an snv whith advacned edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
changed the title
|
rdenarie
approved these changes
Dec 4, 2024
exo-swf
pushed a commit
that referenced
this pull request
Dec 5, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 5, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 6, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
exo-swf
pushed a commit
that referenced
this pull request
Dec 6, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
exo-swf
pushed a commit
that referenced
this pull request
Dec 7, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 9, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 9, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 9, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 18, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 18, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 19, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 19, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
rdenarie
pushed a commit
that referenced
this pull request
Dec 20, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
hakermi
added a commit
that referenced
this pull request
Dec 23, 2024
…2642 (#1238) prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save. This PR ensures to ignore validating the title in an snv case to fix thus issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this change, when editing an snv with advanced edition option and adding a translation while automatic translation is disabled, the save button remains disabled as it checks the validity of the note title in the snv while it shouldn't in this case which causes the non validation of the from to enable the save.
This PR ensures to ignore validating the title in an snv case to fix thus issue.