-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: More princess commands - ignore player/turret, order offboard artillery #6615
Open
Scoppio
wants to merge
7
commits into
MegaMek:master
Choose a base branch
from
Scoppio:feat/princess-commands
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6615 +/- ##
============================================
- Coverage 29.17% 29.14% -0.03%
+ Complexity 15444 15423 -21
============================================
Files 2870 2875 +5
Lines 280207 280335 +128
Branches 49325 49343 +18
============================================
- Hits 81738 81704 -34
- Misses 192971 193166 +195
+ Partials 5498 5465 -33 ☔ View full report in Codecov by Sentry. |
39431d7
to
9c90833
Compare
9c90833
to
e45a2ab
Compare
Sleet01
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does?
This PR allows players to select the type of special ammo they want princess to use when shooting, right now it only allows you to select between mine, smoke and flare.
It also gives 5 orders:
It also adds two new commands:
Important
There is already the "Clear ignored targets" which can be used to reset the ignored target units list.