Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More princess commands - ignore player/turret, order offboard artillery #6615

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Feb 25, 2025

What it does?

This PR allows players to select the type of special ammo they want princess to use when shooting, right now it only allows you to select between mine, smoke and flare.

It also gives 5 orders:

  • halt: cease fire immediately.
  • auto: normal behavior
  • single: only one shooter will fire at a target location (if it has multiple target locations in memory it will pick the one that it has better chance of hitting.
  • volley: every arty will shoot once at any of the targets given.
  • barrage: every arty will shoot continuously at the targets provided.

It also adds two new commands:

  • Ignore player: adds every unit from a specific player in the ignored list
  • Ignore turrets: adds every turret in the game in the ignored list

Important

There is already the "Clear ignored targets" which can be used to reset the ignored target units list.

@Scoppio Scoppio self-assigned this Feb 25, 2025
@Scoppio Scoppio added Princess/AI PACAR Any Issues related to the PACAR (Princess Abstract Combat Auto Resolve) System labels Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.14%. Comparing base (b91c55a) to head (00f3d78).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6615      +/-   ##
============================================
- Coverage     29.17%   29.14%   -0.03%     
+ Complexity    15444    15423      -21     
============================================
  Files          2870     2875       +5     
  Lines        280207   280335     +128     
  Branches      49325    49343      +18     
============================================
- Hits          81738    81704      -34     
- Misses       192971   193166     +195     
+ Partials       5498     5465      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio marked this pull request as ready for review February 26, 2025 02:59
@Scoppio Scoppio force-pushed the feat/princess-commands branch from 39431d7 to 9c90833 Compare February 26, 2025 03:02
@Scoppio Scoppio force-pushed the feat/princess-commands branch from 9c90833 to e45a2ab Compare February 26, 2025 03:06
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PACAR Any Issues related to the PACAR (Princess Abstract Combat Auto Resolve) System Princess/AI
Projects
None yet
2 participants