Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Troopspace refactor #6629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Feb 27, 2025

This is a small code update around troopspace a.k.a. Infantry Compartment. It moves a few methods up to Transporter as defaults, removes redundant comments and reduces some extreme forms of over-verbose code.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.16%. Comparing base (b91c55a) to head (dcc0f8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6629      +/-   ##
============================================
- Coverage     29.17%   29.16%   -0.01%     
+ Complexity    15444    15430      -14     
============================================
  Files          2870     2870              
  Lines        280207   280183      -24     
  Branches      49325    49320       -5     
============================================
- Hits          81738    81705      -33     
- Misses       192971   192994      +23     
+ Partials       5498     5484      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psikomonkie
Copy link
Collaborator

What is this for? This looks like it'll conflict with #6627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants