Bugfix/remove null appinfo (#15)

* remove null appinfo from event for bugit * remove null appinfo in a correct way
Meituan-Dianping · Oct 22, 2018 · 1c3e6e7 · 1c3e6e7
1 parent 0b84bb1
commit 1c3e6e7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/lyrebird_ios/device_service.py b/lyrebird_ios/device_service.py
@@ -58,25 +58,25 @@ def start_log_recorder(self, device_id):
     def publish_devices_info_event(self, online_devices):
         devices = []
         for item in online_devices:
-            info = online_devices[item]
-            app = online_devices[item].get_app_info(self.get_default_app_name())
-            devices.append(
-                {
-                    'id': info.device_id,
-                    'info': {
-                        'name': info.device_name,
-                        'model': info.model,
-                        'os': info.os_version,
-                        'sn': info.sn
-                    },
-                    'app': {
-                        'name': app['AppName'],
-                        'version': app['VersionNumber'],
-                        'build': app['BuildNumber'],
-                        'bundleID': app['BundleID']
-                    }
+            device_info = online_devices[item]
+            app_info = online_devices[item].get_app_info(self.get_default_app_name())
+            message_info = {
+                'id': device_info.device_id,
+                'info': {
+                    'name': device_info.device_name,
+                    'model': device_info.model,
+                    'os': device_info.os_version,
+                    'sn': device_info.sn
+                },
+            }
+            if app_info.get('AppName'):
+                message_info['app'] = {
+                    'name': app_info['AppName'],
+                    'version': app_info['VersionNumber'],
+                    'build': app_info['BuildNumber'],
+                    'bundleID': app_info['BundleID']
                 }
-            )
+            devices.append(message_info)
         lyrebird.publish('ios.device', devices, state=True)
 
     @staticmethod

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 
 setup(
     name='lyrebird-ios',
-    version='0.1.12',
+    version='0.1.13',
     packages=['lyrebird_ios'],
     url='https://github.com/meituan/lyrebird-ios',
     author='HBQA',