Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Initialize Git repository #21

Merged
merged 15 commits into from
Nov 11, 2023

Conversation

SudoSurya
Copy link
Contributor

Added a command to execute npx gitignore go. The command generates a .gitignore file configured for Go projects.

cmd/program/program.go Outdated Show resolved Hide resolved
@SudoSurya
Copy link
Contributor Author

I made changes by injecting a .gitignore file instead of using NPX

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go build failing out

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I am approving but I will give you the option to merge because the current default branch is master.
I will leave it to you if you want to change it to main. If you do re-request my review, otherwise merge ahead!

cmd/program/program.go Outdated Show resolved Hide resolved
@SudoSurya
Copy link
Contributor Author

i made changes that now git branch defaults to main not master

@Melkeydev
Copy link
Owner

Unfortunately:

Error: exit status 128

This is what happens when I spin up a new project

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spinning up new project is failing - please see comment

@SudoSurya

This comment has been minimized.

@SudoSurya

This comment has been minimized.

@SudoSurya

This comment has been minimized.

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what i am doing wrong but:
I pulled your fork, fetched the latest commits and tried to do the same with the same error:

2023/11/09 13:22:20 Error renaming master branch to main: exit status 128
Error: exit status 128

@SudoSurya
Copy link
Contributor Author

so i cant figure out the issue with switching to main branch. it working on my side (i tested on my friends machine it worked fine)
anyway it not working on your side (i assume it has to do with some git issue or setting). so for now its good to stick with master
branch .so i removed git branch -m main cmd.

@SudoSurya
Copy link
Contributor Author

i removed switching to main branch cmd. you can review changes and merge if you think sticking with master branch is ok

@basokant
Copy link
Contributor

i removed switching to main branch cmd. you can review changes and merge if you think sticking with master branch is ok

👍 I think this is fine too, especially considering that running git init will use the default branch setting on the user's machine, which most people have set to main anyway. And it's easy enough for the user to rename the branch anyway. Good work on the PR!

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Melkeydev Melkeydev merged commit ae4df06 into Melkeydev:main Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants