-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Initialize Git repository #21
Conversation
81ec1f5
to
f29bc17
Compare
I made changes by injecting a .gitignore file instead of using NPX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go build failing out
ab228a9
to
f29bc17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am approving but I will give you the option to merge because the current default branch is master.
I will leave it to you if you want to change it to main. If you do re-request my review, otherwise merge ahead!
i made changes that now git branch defaults to main not master |
Unfortunately:
This is what happens when I spin up a new project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spinning up new project is failing - please see comment
fa551f0
to
0f1e925
Compare
0f1e925
to
1a3dd59
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what i am doing wrong but:
I pulled your fork, fetched the latest commits and tried to do the same with the same error:
2023/11/09 13:22:20 Error renaming master branch to main: exit status 128
Error: exit status 128
so i cant figure out the issue with switching to main branch. it working on my side (i tested on my friends machine it worked fine) |
i removed |
👍 I think this is fine too, especially considering that running git init will use the default branch setting on the user's machine, which most people have set to main anyway. And it's easy enough for the user to rename the branch anyway. Good work on the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a command to execute
npx gitignore go
. The command generates a .gitignore file configured for Go projects.