Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting before approval #88

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Linting before approval #88

merged 2 commits into from
Nov 12, 2023

Conversation

CamPen21
Copy link
Collaborator

Motivation

Running this workflow after approval causes reprocessing as it may or may not break. If it does break unfortunately changes need to happen and a new review needs to be done.

Changes

  • The workflow runs on a push, this will run more frequently but I have added caching to deps to make it fast enough so it's not annoyingly slow.

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Melkeydev Melkeydev merged commit 9541527 into Melkeydev:main Nov 12, 2023
8 checks passed
@CamPen21 CamPen21 deleted the fix/devops branch November 12, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants