Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getFromNamespace instead of ::: to fix S3 dispatch for as_gt() #492

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Use getFromNamespace instead of ::: to fix S3 dispatch for as_gt() #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/as_gt.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,5 +421,6 @@ gsd_parts <- function(

#' @export
as_gt.simtrial_gs_wlr <- function(x, ...) {
simtrial:::as_gt.simtrial_gs_wlr(x, ...)
f <- utils::getFromNamespace("as_gt.simtrial_gs_wlr", "simtrial")
f(x, ...)
}
19 changes: 0 additions & 19 deletions cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +0,0 @@
# gsDesign2 1.1.3

We are aware of the following NOTE, and we also maintain {simtrial}:

```
* checking dependencies in R code ... NOTE
Missing object imported by a ':::' call: ‘simtrial:::as_gt.simtrial_gs_wlr’
```


# gsDesign2 1.0.7

## Resubmission

This is a resubmission. In this version I have:

* Exported the internal functions to avoid the use of ::: in code examples.

* Fixed the write path issue by moving the test fixture generation script to data-raw/ which is not included in the package.