Refactor methods by passing table metadata as attributes #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #482 to refactor the classes/methods as discussed in #457
This PR refactors the
fixed_design_X()
functions to define their owndesign_display
,title
, andfootnote
as attributes, which are then used bysummary()
,as_gt()
, andas_rtf()
. This idea was proposed by @yihui, which I described in #482 (comment)By using the above strategy, I was able to make the following improvements to the classes/methods:
summary.fixed_design()
no longer adds a method class to its output object (eg"ahr"
) since this is no longer necessary. This was only used to constructed the table metadata, which is now already defined in the attributes of the object produced the respectivefixed_design_X()
functionsummary.fixed_design()
returns an object of class"fixed_design_summary"
to distinguish it from the output of afixed_design_X()
function (with class"fixed_design"
)Below is example code to test out the changes in this PR: