fix: Improve srcset rewriter to handle descriptors correctly. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation failed to properly rewrite srcset attributes when they contained descriptors (like 1.5x, 2x). Updated the parser to preserve descriptors while rewriting URLs.
|
The sweat daddy Cloudflare is still preventing us from accessing with this. https://good.site/scramjet/blob:https://trycloudflare.com/long_uuid?dest=worker |
|
Em.. Sir, it looks like the Playwright test didn't pass. And It seems that Youtube is blocking Github actions' IP. |
|
thank you! can you quickly acknowledge that you agree to the license agreement by leaving a thumbs up on this message? i should be able to merge this as soon as i run a few tests |
Percslol
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation failed to properly rewrite srcset attributes when they contained descriptors (like 1.5x, 2x). Updated the parser to preserve descriptors while rewriting URLs.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#srcset