Improve binding build times. #3738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adalisk-emikhaylov
force-pushed
the
mrbind-speedup
branch
from
63502d4
to
74bc7f6
Compare
Grantim
approved these changes
Nov 22, 2024
Comment on lines
+213
to
+214
| // But skipping it here prevents the vector-of-futures type from being registered, which is helpful. | ||
| MRMESH_API MR_BIND_IGNORE Expected<std::vector<std::future<Expected<void>>>> serializeRecursive( const std::filesystem::path& path, Json::Value& root, int childId ) const; |
There was a problem hiding this comment.
we need to think how to prevent this behavior mb add TODO
Comment on lines
+267
to
+292
| NUM_FRAGMENTS := 8 | ||
| # The default number of jobs. Override with `-jN` or `JOBS=N`, both work fine. | ||
| JOBS := 8 | ||
| else ifeq ($(call safe_shell,echo $$(($(ASSUME_RAM) >= 32))),1) | ||
| override ram_string := ~32G | ||
| NUM_FRAGMENTS := 16 | ||
| JOBS := 8 | ||
| else ifeq ($(call safe_shell,echo $$(($(ASSUME_RAM) >= 16))),1) | ||
| override ram_string := ~16G | ||
| NUM_FRAGMENTS := 64 | ||
| JOBS := 8 | ||
| else | ||
| override ram_string := ~8G (oof) | ||
| NUM_FRAGMENTS := 64 | ||
| JOBS := 4 | ||
| endif | ||
| else | ||
| override ram_string := unknown, assuming ~16G | ||
| NUM_FRAGMENTS := 64 | ||
| JOBS := 8 | ||
| endif | ||
| MAKEFLAGS += -j$(JOBS) | ||
| ifeq ($(filter-out file,$(origin NUM_FRAGMENTS) $(origin JOBS)),) | ||
| $(info RAM $(ram_string), defaulting to NUM_FRAGMENTS=$(NUM_FRAGMENTS) -j$(JOBS)) | ||
| else | ||
| $(info RAM $(ram_string), NUM_FRAGMENTS=$(NUM_FRAGMENTS) -j$(JOBS)) |
There was a problem hiding this comment.
should we use more than 8 jobs if we can?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.