-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content update/house of ethereum/layer 2 #369
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added Giveth and Mirror under DAO Funding. Made a few minor capitalization and punctuation edits. Added some to the events section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the issue with the link to the playbook, this looks good. I would like to see less commits ideally - looks like whatever you used to make the edits was making commits on every save?
|
||
- What is [layer 2?](https://ethereum.org/en/layer-2/) | ||
- Check out the [House of L2s and Sidechains](https://wiki.metagame.wtf/great-houses/house-of-L2s) | ||
- Follow this Playbook to [configure Polygon for MetaMask and get some gas](https://wiki.metagame.wtf/playbooks/how-to-install-wallet-get-gas.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link takes the user to a Page not found error page. When you're linking to pages in the wiki, you don't want to include the file extension .md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tommycomma you'll also want to make sure that the .md
extension is removed from the MM playbook URL
Yea, I did it wrong. Should I redo it all as one commit and a new pull request? |
Sorry, I didn't see this. A new PR would be sweet if it isn't too much bother. Also, it is good practice to not work from the |
Updated the section on Layer 2 to lead to our House of Layer 2 link and the new playbook on setting up a wallet and getting gas. Some of the old links were invalid. And the information was dated. I for now deleted the section on xDai rather than updating it to Gnosis, mainly to keep it focused at the moment on Polygon and to hyperlink back to resources we currently have created.