Feature/tx local state logs #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Mar 30, 2021
rekmarks
reviewed
Mar 31, 2021
Co-authored-by: Erik Marks <[email protected]>
Updated string enum values Co-authored-by: Erik Marks <[email protected]>
Gudahtt
reviewed
Mar 31, 2021
Gudahtt
reviewed
Mar 31, 2021
Gudahtt
previously approved these changes
Apr 2, 2021
Gudahtt
approved these changes
Apr 2, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added property to transaction if it was confirmed locally * added logic to capture the time an account was added/imported * coverted confirmDevice to enum and removed console.logs * updated package.json * Update src/transaction/TransactionController.ts Co-authored-by: Erik Marks <[email protected]> * format * updated variable name to make more sense * Update src/transaction/TransactionController.ts Updated string enum values Co-authored-by: Erik Marks <[email protected]> * reverted the version number * move importTime to preferences controller and added test cases * updated setting of import time and test cases * updated test case * updated format * updated enum name per PR suggestion * format Co-authored-by: Erik Marks <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added property to transaction if it was confirmed locally * added logic to capture the time an account was added/imported * coverted confirmDevice to enum and removed console.logs * updated package.json * Update src/transaction/TransactionController.ts Co-authored-by: Erik Marks <[email protected]> * format * updated variable name to make more sense * Update src/transaction/TransactionController.ts Updated string enum values Co-authored-by: Erik Marks <[email protected]> * reverted the version number * move importTime to preferences controller and added test cases * updated setting of import time and test cases * updated test case * updated format * updated enum name per PR suggestion * format Co-authored-by: Erik Marks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the following functionality to the controllers: