gh-pages: Add method to share connection status #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
commented
May 9, 2022
6 tasks
digiwand
reviewed
May 12, 2022
ledger-bridge.js
Outdated
| } | ||
| catch(e) { | ||
| console.log('LEDGER:::Transport check error', e) | ||
| this.sendConnectionMessage(false) |
There was a problem hiding this comment.
this.onDisconnect() below also appears to call this.sendConnectionMessage(false). Maybe we don't need this line? Same comment applies to similar logic added in bundle.js
darkwing
commented
May 13, 2022
ledger-bridge.js
Outdated
| // Ensure the correct (Ethereum) app is open; if not, immediately kill | ||
| // the connection as the wrong app is open and switching apps will call | ||
| // a disconnect from within the Ledger API | ||
| try { |
There was a problem hiding this comment.
This block needs to be skipped for Firefox because the U2F library throws on the await this.transport.send(0xb0, 0x01, 0x00, 0x00) line.
brad-decker
previously approved these changes
May 16, 2022
darkwing
force-pushed
the
gh-pages-disconnect
branch
3 times, most recently
from
963e99f to
1218a25
Compare
darkwing
force-pushed
the
gh-pages-disconnect
branch
from
1218a25 to
94dce64
Compare
digiwand
approved these changes
Jun 17, 2022
| catch(e) { | ||
| console.log('LEDGER:::Transport check error', e) | ||
| // A race condition for checking connection status isn't a sign that | ||
| // connection status has changed, so don't disconnect on this type of error |
There was a problem hiding this comment.
[optional] It might be helpful if we add a link to the error name
@see {@link https://github.com/LedgerHQ/ledgerjs/blob/master/packages/hw-transport/src/Transport.ts#L276}
for more context of the 'TransportRaceCondition' error. This is subject to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method for the Ledger to ensure the correct app is open during connection, as well as share track and share connectivity for the Hardware Connectivity UI (MetaMask/metamask-extension#12725)