Remove engineering as a CODEOWNER #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
GitHub codeowners allow us to ensure that a specific group of people with write access are able to gate whether or not a pull request is allowed to be merged. It does this by adding them as a reviewer to every PR touching the designated files.
Problem
The problem with adding engineering as a codeowner is that each time a pull request in this repo is made, every member of our engineering team is hit with a notification. While codeowners make sense in cases where we want a specified group to gate changes, it becomes redundant where the code owning group is the entire engineering team.
Solution
Remove the code owner, and instead ensure that 1 approval is required before a pull request can be merged. This means that we still enforce a member of our engineering team to approve the pull request prior to a change being made, but now we are not sending review request notifications to everyone.