Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add team label implementation #27

Merged
merged 37 commits into from
Aug 20, 2024
Merged

feat: Add team label implementation #27

merged 37 commits into from
Aug 20, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Aug 1, 2024

This PR adds the implementation of the add-team-label workflow. It also massively improves the original implementation.

  • Provides proper error message with instructions on failure.
  • Increased performance by converting the javascript code to a simple shell script: Compute time reduced from about 2 minutes to ~3-5 secs

Fixes: #24

@itsyoboieltr itsyoboieltr self-assigned this Aug 1, 2024
itsyoboieltr added a commit to MetaMask/metamask-extension that referenced this pull request Aug 20, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26540?quickstart=1)

This PR is a one-line fix to stick the version of the add-team-label
workflow to the commit hash instead of the branch name. This is
particularly important due to the breaking change we are introducing to
main, as giving write permissions for pull requests is now required as
the workflow was reworked in
MetaMask/github-tools#27.

## **Related issues**

Fixes: MetaMask/github-tools#24

## **Manual testing steps**

1. Team label should be added automatically when PR is opened

## **Screenshots/Recordings**

Not applicable

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@itsyoboieltr itsyoboieltr merged commit 058012b into main Aug 20, 2024
7 checks passed
@itsyoboieltr itsyoboieltr deleted the add-team-label branch August 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add-team-label workflow is missing implementation
2 participants