Improve options handling in setup command #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhattan
force-pushed
the
commands-setup-getopt
branch
from
1b72ecd to
039e7d4
Compare
jonhattan
changed the title
juanjol
force-pushed
the
main
branch
21 times, most recently
from
5f52d63 to
06191f1
Compare
|
This is a good option, I thing that we have to adapt it to the new commands, let me take a look on it. |
|
I have been researching this and I am not 100% convinced to use getopt. It's not a standardised command, and the intention of the script is actually to switch to sh (currently the shebang is in bash but I want to change this) and try to be as basic and standard as possible. In fact getopt doesn't work on Mac either. We need to turn this around, for now I'm going to leave it to manual parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.