Migration to meteor 3.0 #1737

jankapunkt · 2023-12-19T11:38:06Z

This is an ongoing PR. With every update this description will extend.

Related migration for the themes: Meteor-Community-Packages/meteor-autoform-themes#10

…ckages/meteor-autoform into migration/meteor-3.0

…utoform into migration/meteor-3.0

jankapunkt · 2024-07-29T13:48:55Z

published 8.0.0-rc.4 which also makes momentjs:moment a true optional dependency

jankapunkt · 2024-10-04T15:01:11Z

If there are no deep issues with this release then I will publish 8.0.0 next week

TMeerhof · 2024-11-04T10:23:25Z

When is this PR getting merged? The comment said next week, and it has been a month.
It would be really helpful for us, thanks!
I tested it by installing the PR branch locally, and it seems to work fine based on some superficial testing.

jankapunkt · 2024-11-04T16:05:36Z

@TMeerhof sorry too much on my plate this autumn. Unfortunately nobody made a code-review and I personally did not tests against all my apps due my current crunch.

Anyone who can help out with a code review o feedback on RC.4? // @harryadel @ricaragao @lynchem @polygonwood @manueltimita

polygonwood · 2024-11-04T16:58:28Z

Jan I have limited experience in code reviews, I can give it a try. Can you point me to the pull request ? I see 3 pull requests in meteor-autoform on Github, is it one of those 3 ? Or is this on another fork ? regards Polygonwood

…

On Mon, Nov 4, 2024 at 5:05 PM Jan Küster ***@***.***> wrote: @TMeerhof <https://github.com/TMeerhof> sorry too much on my plate this autumn. Unfortunately nobody made a code-review and I personally did not tests against all my apps due my current crunch. Anyone who can help out with a code review o feedback on RC.4? // @harryadel <https://github.com/harryadel> @ricaragao <https://github.com/ricaragao> @lynchem <https://github.com/lynchem> @polygonwood <https://github.com/polygonwood> @manueltimita <https://github.com/manueltimita> — Reply to this email directly, view it on GitHub <#1737 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTJC25KT5MKRFRDHHV7LLTZ66LOPAVCNFSM6AAAAABA3A5IWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGEYDQMBWHA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

jankapunkt · 2024-11-04T18:04:53Z

@polygonwood Thank you for participating! It's exactly this PR you just have just commented. The files changed tab allows you to view all code changes of this PR and you can add comments (start review) to respective lines and even suggest changes.

Your comments through review will be pending until you submit the review so you can freely add or remove them before they get attached to this pull request. The GitHub docs are also very helpful on the topic.

polygonwood · 2024-11-04T20:42:50Z

OK I do have some time available Thu/Fri this week, I will have look at it (new experience ...) regards Ronny

…

On Mon, Nov 4, 2024 at 7:05 PM Jan Küster ***@***.***> wrote: @polygonwood <https://github.com/polygonwood> Thank you for participating! It's exactly this PR you just have just commented. The files changed tab <https://github.com/Meteor-Community-Packages/meteor-autoform/pull/1737/files> allows you to view all code changes of this PR and you can add comments (start review) to respective lines and even suggest changes. Your comments through review will be pending until you submit the review so you can freely add or remove them before they get attached to this pull request. The GitHub docs are also very helpful on the topic. — Reply to this email directly, view it on GitHub <#1737 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTJC2YMDEZ5BXVYY4S7E73Z66ZNZAVCNFSM6AAAAABA3A5IWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGM3TKNBVGM> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

polygonwood · 2024-11-15T08:38:12Z

getMoment.js

do we still need moment ? javascript date functions are not sufficient ? If not, is moment the better choice versus e.g. luxon ?

we stick with moment for backwards compatibility but its a weak dependency and should 100% work without moment being installed and it should also not cause moment being added to .meteor/versions

I agree with Jan. It's best to keep it as is for now and update things in a later bump.

polygonwood

Reviewed as an AutoForm user. Missing is some form of documentation of what has been changed and what were the drivers to do so. Changes look OK and properly coded.

polygonwood · 2024-11-15T08:54:18Z

Jan sorry I had some delay but I submitted my review. Not easy for a 'user' to review the internals :-) In my app we use Autoform quite extensively, we go live this weekend with M3 version, I have not encountered any difficulties. Once this version 8.x.x is official, I will add some pull requests on some extensions/modifications we have added (and which are now in local packages). regards Polygonwood

…

On Mon, Nov 4, 2024 at 7:05 PM Jan Küster ***@***.***> wrote: @polygonwood <https://github.com/polygonwood> Thank you for participating! It's exactly this PR you just have just commented. The files changed tab <https://github.com/Meteor-Community-Packages/meteor-autoform/pull/1737/files> allows you to view all code changes of this PR and you can add comments (start review) to respective lines and even suggest changes. Your comments through review will be pending until you submit the review so you can freely add or remove them before they get attached to this pull request. The GitHub docs are also very helpful on the topic. — Reply to this email directly, view it on GitHub <#1737 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTJC2YMDEZ5BXVYY4S7E73Z66ZNZAVCNFSM6AAAAABA3A5IWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVGM3TKNBVGM> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

ricaragao · 2024-11-19T04:45:49Z

Yes, I can @jankapunkt . I'm starting to migrate some Meteor Apps that use this package, so I can review and test the code. Did you publish this RC version to meteor package? Or should I clone the repository?

@TMeerhof sorry too much on my plate this autumn. Unfortunately nobody made a code-review and I personally did not tests against all my apps due my current crunch.

Anyone who can help out with a code review o feedback on RC.4? // @harryadel @ricaragao @lynchem @polygonwood @manueltimita

jankapunkt · 2024-11-21T20:05:32Z

@ricaragao yes the 8.0.0 RC releases are available as Meteor packages

jankapunkt · 2024-11-21T20:07:41Z

@polygonwood thanks a lot for the testing and review! If I understand you correctly then you would want some form of changelog for the 8.0.0 release, correct?

I can try to add it and update the README in general, I think it contains some outdated links.

polygonwood · 2024-11-22T07:04:41Z

Jan changelog is for sure interesting for those that are migrating, but as a (first time) reviewer what would be interesting is a (short) description of what is being changed and why. E.g. I noticed the change in the ArrayTracker, I can guess it's because of Async issues - or Blaze changes, but I also noticed changes from 'function' to 'class' (which is a good change of course), but was this driven by 3.0 migration or just a beautification ? regards Polygonwood

…

On Thu, Nov 21, 2024 at 9:08 PM Jan Küster ***@***.***> wrote: @polygonwood <https://github.com/polygonwood> thanks a lot for the testing and review! If I understand you correctly then you would want some form of changelog for the 8.0.0 release, correct? I can try to add it and update the README in general, I think it contains some outdated links. — Reply to this email directly, view it on GitHub <#1737 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTJC22X7QLGGCPIXC6IRS32BY4SJAVCNFSM6AAAAABA3A5IWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGE3DIMBYGA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

harryadel · 2024-11-23T11:06:41Z

.github/workflows/testsuite.yml


      - name: Setup meteor
        uses: meteorengineer/setup-meteor@v1
        with:
-          meteor-release: '1.10.1'
+          meteor-release: '3.0-rc.4'


Might be worth a version bump to the latest version 3.1

harryadel · 2024-11-23T11:07:52Z

CONTRIBUTING.md

@@ -37,49 +36,7 @@ Any code change should be submitted as a pull request. The description should ex
 The bigger the pull request, the longer it will take to review and merge. Try to break down large pull requests in smaller chunks that are easier to review and merge.
 It is also always helpful to have some context for your pull request. What was the purpose? Why does it matter to you?

-## Financial contributions


Please bring it back and link to yourself and/or Czech Jan. You're doing great work and should be compensated if possible.

harryadel · 2024-11-23T11:11:03Z

autoform-arrays.js

-  const self = this
-  self.info = {}
-}
+export class ArrayTracker {


Good job using Class syntax 👍

harryadel · 2024-11-23T11:18:32Z

package.js


 Package.onUse(function (api) {
-  api.versionsFrom('[email protected]')
+  api.versionsFrom(['3.0.1'])


It's to keep versionsFrom in sync with CI meteor version.

harryadel

I did take a look around, there doesn't seem to be any major changes like I had feared. I'd recommend doing a beta release so others can test things out.

harryadel · 2024-12-23T13:03:46Z

@jankapunkt Is there anything holding this PR back from merging?

jankapunkt · 2025-01-04T08:43:09Z

Published 8.0.0

jankapunkt added 3 commits December 19, 2023 11:46

build: bump versions to be generally 3.0 compatible

4232fe2

tests: updated testapp to Meteor 2.14

3fd6b90

tests: minimal demo added

5473371

jankapunkt mentioned this pull request Dec 19, 2023

Migrate to Meteor 3.0 Meteor-Community-Packages/meteor-autoform-themes#10

Merged

ricaragao and others added 6 commits March 5, 2024 03:23

Update to force to use Meteor 3

dd442a8

build: package.js versionsFrom fixed

3546d04

build: removed jshintrc

f8187bb

Merge branch 'migration/meteor-3.0' of github.com:Meteor-Community-Pa…

e477159

…ckages/meteor-autoform into migration/meteor-3.0

fix(deps/tests): make tests run agagin

bbc334a

tests: 3.0 testapp project added

ed30b36

jankapunkt marked this pull request as ready for review April 17, 2024 09:59

jankapunkt added 12 commits April 17, 2024 12:02

Merge branch 'devel' of github.com:Meteor-Community-Packages/meteor-a…

fa09014

…utoform into migration/meteor-3.0

build(tests): update npm deps

c83df82

fix: move es5 to es6 and use exports instead of globals

03279f9

tests: add 3.0 test project

d1b0aa5

make 3.0 compatible

85e221d

publish 8.0.0-rc.1

47bfac2

Merge branch 'devel' of github.com:Meteor-Community-Packages/meteor-a…

edf033d

…utoform into migration/meteor-3.0

tests: updated to 3.0 rc.4

c042013

ci: updated to 3.0 rc.4

a034abc

tests: remove 2x test app

91c4e86

published 8.0.0-rc.3

d708e0c

deps: make momentjs true optional dependency

7e9db73

jankapunkt requested review from ricaragao and harryadel July 29, 2024 13:49

polygonwood reviewed Nov 15, 2024

View reviewed changes

harryadel reviewed Nov 23, 2024

View reviewed changes

autoform-arrays.js

const self = this

self.info = {}

}

export class ArrayTracker {

Copy link

Member

harryadel Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job using Class syntax 👍

harryadel reviewed Nov 23, 2024

View reviewed changes

harryadel approved these changes Nov 23, 2024

View reviewed changes

ricaragao approved these changes Dec 28, 2024

View reviewed changes

jankapunkt added 4 commits January 2, 2025 10:57

deps(ci): update Meteor release to 3.1

0829ccb

tests: updated test project to 3.x

d9bf17d

fix(modules): use module.exports for globals compatibility

b18fe6c

published 8.0.0

60fb1ae

jankapunkt merged commit 018c2d0 into devel Jan 4, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration to meteor 3.0 #1737

Migration to meteor 3.0 #1737

jankapunkt commented Dec 19, 2023 •

edited

Loading

jankapunkt commented Jul 29, 2024

jankapunkt commented Oct 4, 2024

TMeerhof commented Nov 4, 2024 •

edited

Loading

jankapunkt commented Nov 4, 2024

polygonwood commented Nov 4, 2024 via email

jankapunkt commented Nov 4, 2024

polygonwood commented Nov 4, 2024 via email

polygonwood Nov 15, 2024

jankapunkt Nov 21, 2024

harryadel Nov 23, 2024

polygonwood left a comment

polygonwood commented Nov 15, 2024 via email

ricaragao commented Nov 19, 2024

jankapunkt commented Nov 21, 2024

jankapunkt commented Nov 21, 2024

polygonwood commented Nov 22, 2024 via email

harryadel Nov 23, 2024

harryadel Nov 23, 2024

harryadel Nov 23, 2024

harryadel Nov 23, 2024

harryadel left a comment

harryadel commented Dec 23, 2024

jankapunkt commented Jan 4, 2025

Migration to meteor 3.0 #1737

Migration to meteor 3.0 #1737

Conversation

jankapunkt commented Dec 19, 2023 • edited Loading

jankapunkt commented Jul 29, 2024

jankapunkt commented Oct 4, 2024

TMeerhof commented Nov 4, 2024 • edited Loading

jankapunkt commented Nov 4, 2024

polygonwood commented Nov 4, 2024 via email

jankapunkt commented Nov 4, 2024

polygonwood commented Nov 4, 2024 via email

polygonwood Nov 15, 2024

Choose a reason for hiding this comment

jankapunkt Nov 21, 2024

Choose a reason for hiding this comment

harryadel Nov 23, 2024

Choose a reason for hiding this comment

polygonwood left a comment

Choose a reason for hiding this comment

polygonwood commented Nov 15, 2024 via email

ricaragao commented Nov 19, 2024

jankapunkt commented Nov 21, 2024

jankapunkt commented Nov 21, 2024

polygonwood commented Nov 22, 2024 via email

harryadel Nov 23, 2024

Choose a reason for hiding this comment

harryadel Nov 23, 2024

Choose a reason for hiding this comment

harryadel Nov 23, 2024

Choose a reason for hiding this comment

harryadel Nov 23, 2024

Choose a reason for hiding this comment

harryadel left a comment

Choose a reason for hiding this comment

harryadel commented Dec 23, 2024

jankapunkt commented Jan 4, 2025

jankapunkt commented Dec 19, 2023 •

edited

Loading

TMeerhof commented Nov 4, 2024 •

edited

Loading