Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest socket.io version #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MariusVB
Copy link

Please update to the latest socket.io client, as backends start to implement it.

Please update to the latest socket.io client, as backends start to implement it.
@Heiss
Copy link

Heiss commented Feb 5, 2021

Is this version update already tested?

@franjid
Copy link

franjid commented Feb 28, 2021

Any reason why this PR hasn't been accepted yet?

@jeremy-prater
Copy link

jeremy-prater commented May 25, 2021

From the following compatibility table

https://github.com/miguelgrinberg/python-socketio

Using a 2.x JS client limits which server versions are compatible. I regenerated a python virtual env (My back end service) and it pulled in the latest Socket.IO server, which does not work with the 2.x JS client. And thus, my vue application is dead in the water now 😢

@jeremy-prater
Copy link

jeremy-prater commented May 25, 2021

Actually, looking at the change notes from 2.x to 3.x

https://socket.io/docs/v3/migrating-from-2-x-to-3-0/index.html

We will need the ability to pass in some CORS options

Disregard... You can already pass constructor options to the SocketIO constructor 👍 Should be good to merge

https://github.com/MetinSeylan/Vue-Socket.io/blob/master/src/index.js#L65

@MariusVB
Copy link
Author

Great, thanks! Let's merge it :)

@jeremy-prater
Copy link

Similar PR in the same repo...
#303

I'm not sure who has write access to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants