Optimize person detail page #1117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bdefd09.
hancush
reviewed
Jun 10, 2024
lametro/views.py
Outdated
| @@ -701,13 +701,15 @@ def get_context_data(self, **kwargs): | |||
| except AttributeError: | |||
| context["map_geojson"] = None | |||
|
|
|||
| if person.committee_sponsorships: | |||
| context["sponsored_legislation"] = person.committee_sponsorships | |||
| sponsored_legislation = list(person.committee_sponsorships.iterator()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See title. Locally, I saw database calls on person detail pages reduce by about half.
Notes
Evaluating the Queryset returned by
LAMetroPerson.committee_sponsorshipson Heroku takes anywhere from several minutes to sometimes 10+ seconds (along with spiking memory usage). Since we're only evaluating the Queryset once, I dropped in an iterator to see if the lack of caching can improve the performance.Connects #1109
Testing Instructions