fix Significant Date facet and add Fiscal Year facet

[fgomez828]

Overview

See title

Checklist

• PR has a descriptive enough title to be useful in changelogs

Testing Instructions

[for @fatima3558 to do]

• Deploy to staging by shelling into the lametro server
• run the refresh_guid command on the staging server
• visit the staging site and check that the Significant Date facet is properly populated

Handles #716
Handles #370

[hancush]

Thanks for your tenacity on this, @fatima3558. The new code is in the right place – the logic just needs a little revision!

Let's chat at the start of your next Metro block. I want to sync up on some of the finer (and undocumented 🙀) parts of search indexing before you bring this over the line.

[hancush]

This is already defined on the base index in django-councilmatic – why redefine here?

[hancush]

This isn't quite right. The desired logic is to return the session associated with the most recent agenda date. If there are no agenda dates, return the session associated with the most recent action date. If there is neither an agenda date nor an action date, return None.

[hancush]

Can you propose how you'd go about getting the desired date, using the output of obj.actions_and_agendas?

[fgomez828]

As I'm thinking about it, I would have to add additional logic to check if the most_recent event is an agenda (description being SCHEDULED) or an action. I would use the agenda if possible, otherwise using an action as the most_recent.

Either way, I can use most_recent['date'], unless a datetime instance is preferable to a date instance for this?

[fgomez828]

@hancush am I on the right track with this?

[hancush]

I'd recommend something like:

actions_and_agendas = sorted(obj.actions_and_agendas, key=lambda i: i['date'], reverse=True)
agendas = [item for item in actions_and_agendas if it is an agenda]  # will be sorted bc list order is preserved in python
if agendas:
    # return the most recent date from your agendas list
else:
    # there are no agendas, i.e., everything in actions_and_agendas is an action
    # return the most recent date from your actions_and_agendas list

Stale review