Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use board member titles from Legistar #10

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

antidipyramid
Copy link
Collaborator

Overview

This PR amends the people scraper to pull board member titles from Legistar.

Related to Metro-Records/la-metro-councilmatic#1045

Because the titles for a few posts in Legistar differ slightly from our current titles (e.g. Appointee of the Mayor vs Appointee of Mayor), we'll have a some duplicates after the first scrape. We can either delete them manually or wait on the pupa clean command.

Testing Instructions

  • Verify that you can run a people scrape successfully with docker compose run --rm scrapers pupa update lametro people

@antidipyramid antidipyramid force-pushed the feature/legistar-member-titles branch from 4004efc to 9a65ea7 Compare December 15, 2023 21:50
Copy link
Collaborator

@hancush hancush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's wait to merge and deploy until the New Year, that way we can clean up (we won't want to wait a week for the pupa clean command) and monitor for any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants