Alert sentry when no attachments found for approved minutes

[xmedr]

Overview

This pr will alert sentry when an approved minutes matter is missing any attachments, provide details to examine it within legistar, and continue the scrape without failing outright

• Connects Events scraper alerts #24

Testing Instructions

• Check the following test alert in sentry (or trigger your own, read on for details) and confirm that it gives enough details on the situation to be actionable
  • Sentry Alert
• To trigger your own alert:
  • pull down this branch, and insert a breakpoint after line 596 of events.py (after the capture_exception command)
  • after line 553, reassign the attachments var to an empty list
  • Run a big enough scrape to get a matter with potential attachments. I ran docker-compose run --rm scrapers pupa update lametro events window=200 --rpm=0
  • Once you hit the breakpoint, check sentry for the new alert

[antidipyramid]

Multiple indentation levels can make code more difficult to read. What do you think about doing something like:

for matter in result:
...
    try:
        if len(attachments) == 0:
            raise MissingAttachmentsException(matter["MatterId"], attachment_url)
    except MissingAttachmentsException as e:
        capture_exception(e)
        continue

    if len(attachments) == 1:
    ...

[xmedr]

Ah I see what you mean, you're totally right!